Changes to util needed to merge VSD #5205
Conversation
martin-cs
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
| out << symbols.at(name); | ||
| } | ||
|
|
||
| symbol_table_baset::const_iteratort symbol_table_baset::end() const |
There was a problem hiding this comment.
Commit message doesn't match content
| #endif | ||
|
|
||
| #ifndef USE_STRING | ||
| #ifndef USE_STD_STRING |
There was a problem hiding this comment.
Make commit message title more precise.
"various things": there's only one thing in this commit.
|
@peterschrammel Sorry about the commit messages, I kept them from splitting up VSD. First I wanted to get the code right, then the meta-data. If you prefer I will squash everything and write meaningful commit messages first. |
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 5db9d83).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/140335402
This don't show up on travis because the unit tests are currently not being built on Travis if USE_STD_STRING is set. Originally by Hannes Steffenhagen.
Patch originally by Chris Ryder.
|
@peterschrammel I have re-written the commit messages. |
Codecov Report
@@ Coverage Diff @@
## develop #5205 +/- ##
===========================================
- Coverage 67.36% 67.36% -0.01%
===========================================
Files 1157 1157
Lines 95051 95055 +4
===========================================
Hits 64032 64032
- Misses 31019 31023 +4
Continue to review full report at Codecov.
|
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 0e3195c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/140805372
| out << symbols.at(name); | ||
| } | ||
|
|
||
| symbol_table_baset::const_iteratort symbol_table_baset::end() const |
There was a problem hiding this comment.
I’m not sure this change is even necessary; Develop symbol_table_baset already seems to have begin()/end().
There was a problem hiding this comment.
It has a non-const version - this adds a const version
thk123
left a comment
thk123
left a comment
There was a problem hiding this comment.
Commit messages have been tidied up
|
Brought in via #5375 |
6 participants
Another PR from the variable-sensitivity-domain branch. A few minor additions to core things in util/. I have kept the old commit messages to preserve authorship but TBH they should probably be reworded at least.